[Lldb-commits] [PATCH] D142413: [lldb] Don't create Clang AST nodes in GetCPlusPlusQualifiedName

Arthur Eubanks via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 23 15:47:08 PST 2023


aeubanks created this revision.
Herald added a reviewer: shafik.
Herald added a project: All.
aeubanks requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Otherwise we may be inserting a decl into a DeclContext that's not fully defined yet.

GetCPlusPlusQualifiedName() doesn't care about exact spacing between '>', the names it gives just need to be unique. Places that use GetDIEClassTemplateParams() do care about exact spacing (at least until that issue is solved generally).

Reverts part of D138834 <https://reviews.llvm.org/D138834>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142413

Files:
  lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h
  lldb/test/API/lang/cpp/nested-template/Makefile
  lldb/test/API/lang/cpp/nested-template/TestNestedTemplate.py
  lldb/test/API/lang/cpp/nested-template/main.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142413.491529.patch
Type: text/x-patch
Size: 5996 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230123/accafe5a/attachment.bin>


More information about the lldb-commits mailing list