[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D142150#4074015 <https://reviews.llvm.org/D142150#4074015>, @aprantl wrote:

> What about adding a `trivial` parameter to the macro that has the effect of skipping it in instrumentation if the instrumentation is the costly signpost mechanism?

The `_VA` macro is variadic so you'd have to define a new macro, but yeah that's the idea. As discussed offline with Dave, we probably never want timers/signposts for constructors. My suggestion is to re-instrument all constructors with that new "trivial" macro.  During the reproducer era constructs required different macros, so there should be code in `lldb-instr` that can already tell the two apart.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142150/new/

https://reviews.llvm.org/D142150