[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 23 06:10:34 PST 2023


labath added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:32
 
-  DIERef(std::optional<uint32_t> dwo_num, Section section,
+  DIERef(std::optional<uint32_t> dwo_oso_num, Section section,
          dw_offset_t die_offset)
----------------
Where is this constructor being used?


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:10
 #include "SymbolFileDWARFDebugMap.h"
+#include "DIERef.h"
 #include "DWARFCompileUnit.h"
----------------
unused include?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139957/new/

https://reviews.llvm.org/D139957



More information about the lldb-commits mailing list