[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere reopened this revision.
JDevlieghere added a comment.

There's two issues with this patch:

- `LLDB_INSTRUMENT_VA` is not the same as `LLDB_SCOPED_TIMER`. It's used for logging and tracks ABI boundaries. This breaks boundary tracking.
- Next time someone runs `lldb-instr` on this file, the tool will just add this again.

If we want to avoid the overhead from the timer, we'll need to adjust the macro.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142150/new/

https://reviews.llvm.org/D142150