[Lldb-commits] [lldb] 84c6129 - [lldb] Remove timer from SBModule copy ctor

Dave Lee via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 20 13:00:01 PST 2023


Author: Dave Lee
Date: 2023-01-20T12:59:51-08:00
New Revision: 84c6129c943135e2c32b9254f08d0a2e7b21116a

URL: https://github.com/llvm/llvm-project/commit/84c6129c943135e2c32b9254f08d0a2e7b21116a
DIFF: https://github.com/llvm/llvm-project/commit/84c6129c943135e2c32b9254f08d0a2e7b21116a.diff

LOG: [lldb] Remove timer from SBModule copy ctor

The SBModule copy constructor has fast execution, and is high firing. Fast and
frequent functions are not good candidates for timers.

Differential Revision: https://reviews.llvm.org/D142150

Added: 
    

Modified: 
    lldb/source/API/SBModule.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/API/SBModule.cpp b/lldb/source/API/SBModule.cpp
index e7c2b451eb9d..c6bda9da9f61 100644
--- a/lldb/source/API/SBModule.cpp
+++ b/lldb/source/API/SBModule.cpp
@@ -43,9 +43,7 @@ SBModule::SBModule(const SBModuleSpec &module_spec) {
     SetSP(module_sp);
 }
 
-SBModule::SBModule(const SBModule &rhs) : m_opaque_sp(rhs.m_opaque_sp) {
-  LLDB_INSTRUMENT_VA(this, rhs);
-}
+SBModule::SBModule(const SBModule &rhs) = default;
 
 SBModule::SBModule(lldb::SBProcess &process, lldb::addr_t header_addr) {
   LLDB_INSTRUMENT_VA(this, process, header_addr);


        


More information about the lldb-commits mailing list