[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 20 12:36:39 PST 2023


mib added a comment.

In D142245#4069960 <https://reviews.llvm.org/D142245#4069960>, @JDevlieghere wrote:

> In what version of SWIG was this deprecated? We officially support  SWIG 3 and later. What happens with SWIG 3 if you omit the flag, is it a NOOP? If so then this is fine, otherwise we should conditionalize it based on the SWIG version (or propose bumping the minimum to SWIG4). We should include this information in the commit message.
>
> (Requesting changes because Dave already accepted it)

For now, I'll remove the flag conditionally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142245/new/

https://reviews.llvm.org/D142245



More information about the lldb-commits mailing list