[Lldb-commits] [PATCH] D140839: [lldb] Enable TestFrameFormatNameWithArgs in case of cross compilation

[Michael Buch via Phabricator via lldb-commits]

Michael137 added inline comments.


================
Comment at: lldb/test/Shell/helper/build.py:29
                     default='host',
-                    choices=['32', '64', 'host'],
                     help='Specify the architecture to target.')
----------------
asahay wrote:
> Michael137 wrote:
> > Why was this needed?
> > 
> > Other than that, LGTM
> IIUC, //~/lldb/test/Shell/helper/toolchain.py// supplies LLDB's bitness (and not the target architecture) as //arch// to //~/lldb/test/Shell/helper/build.py// unconditionally. However, we may require the target architecture too to customize the compile and link commands (we did in our downstream project, at least). Perhaps, we'd like both, LLDB's bitness and the target architecture to be supplied via separate options but I thought that lifting the restriction in question might've sufficed until we'd provisioned support for the same. Let me know if we'd like it handled (or, not dealt with at all) in this change itself, though, please.
Ah I see. So you're saying currently the build scripts conflate `-m32`/`-m64` with the `-march=<...>` flags? Seems like a separate option for bitness vs. arch would be the way to go

This current patch could be split into a stack of 3:
1. Add `-std` flag
2. Switch the test case to use `%build`

and an independent patch

3. Handle the `--arch` confusion


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140839/new/

https://reviews.llvm.org/D140839