[Lldb-commits] [PATCH] D138792: [AArch64] Improve TargetParser API

[Tomas Matheson via Phabricator via lldb-commits]

tmatheson added a comment.

The most recent versions of this patch contains squashed changes from these reviews:

- D139278 <https://reviews.llvm.org/D139278> "[AArch64] Use string comparison for ArchInfo equality." This fixes the test failures with shared libraries, which were caused by each shared library ending up with it's own copy of the ArchInfo instances and hence breaking the equality-by-address.
- D139102 <https://reviews.llvm.org/D139102> "[AArch64] Inline AArch64TargetParser.def"

The `ArchInfo` class is no longer non-copyable to satisfy C++20. The alternative of adding a constructor would have resulted in global constructor calls, which is not allowed in Support (the same presumably applies to the new TargetParser library).

I've tested locally with `LLVM_BUILD_LLVM_DYLIB=ON` + `LLVM_LINK_LLVM_DYLIB=ON` + `CMAKE_CXX_STANDARD=20`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138792/new/

https://reviews.llvm.org/D138792