[Lldb-commits] [lldb] ade3f1c - [lldb] Fix typo in integral format specifier

[Michael Buch via lldb-commits]

Author: Michael Buch
Date: 2023-01-12T12:09:04Z
New Revision: ade3f1ccd807b00122fdf374ce85987fee60f853

URL: https://github.com/llvm/llvm-project/commit/ade3f1ccd807b00122fdf374ce85987fee60f853
DIFF: https://github.com/llvm/llvm-project/commit/ade3f1ccd807b00122fdf374ce85987fee60f853.diff

LOG: [lldb] Fix typo in integral format specifier

This regressed with `e262b8f48af9fdca8380f2f079e50291956aad71`.

Two issues here:
1. `:16x` is not a valid format specifier and
   we would crash when we encountered this log
   (which was the case in `TestCPPAccelerator.py`)
2. The third argument was missing curly braces so
   the log message itself was malformed.

Added: 
    

Modified: 
    lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
index 162013f369243..9f042e9893bac 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
@@ -430,7 +430,7 @@ TypeSP DWARFASTParserClang::ParseTypeFromDWARF(const SymbolContext &sc,
         log,
         "DWARFASTParserClang::ParseTypeFromDWARF "
         "(die = {0:x16}, decl_ctx = {1:p} (die "
-        "{2:16x})) (3:s) name = '{4}')",
+        "{2:x16})) {3} name = '{4}')",
         die.GetOffset(), static_cast<void *>(context), context_die.GetOffset(),
         die.GetTagAsCString(), die.GetName());
   }