[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

Wed Jan 11 15:50:06 PST 2023

eloparco added inline comments.

================
Comment at: lldb/include/lldb/API/SBTarget.h:844

+  uint32_t GetMaximumOpcodeByteSize() const;
+
----------------
clayborg wrote:
> Do we still need this API change with the new approach? We can't really use this unless we include GetMinimumOpcodeByteSize() and only use this value to backup if the min and max are the same.
In principle we could assume a maximum opcode of size 16 in the calculation, but knowing the maximum actually supported by the architecture can save us from reading unnecessary chunks of memory. In this way, we avoid reading instructions that will then be discarded because resulting in more than `instructionCount` total instructions.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140358/new/

https://reviews.llvm.org/D140358