[Lldb-commits] [PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

[serge via Phabricator via lldb-commits]

serge-sans-paille marked 2 inline comments as done.
serge-sans-paille added a comment.

In D140800#4043723 <https://reviews.llvm.org/D140800#4043723>, @nikic wrote:

> Just to check, this isn't going to cause some warning spew about all those OptTable implementations being non-final?

nope. Why would there be?



================
Comment at: llvm/unittests/Option/OptionParsingTest.cpp:327
 
-TEST(DISABLED_Option, FindNearestFIXME) {
-  TestOptTable T;
----------------
@nikic: the `DISABLED_` prefix seems to be a gtest convention, see https://github.com/google/googletest/blob/main/docs/advanced.md#temporarily-disabling-tests


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140800/new/

https://reviews.llvm.org/D140800