[Lldb-commits] [PATCH] D141021: [lldb] Add lldb-framework-cleanup target

Mon Jan 9 17:01:20 PST 2023

JDevlieghere added a comment.

In D141021#4037840 <https://reviews.llvm.org/D141021#4037840>, @bulbazord wrote:

> I think this idea will work but I have a few comments and questions:
>
> Based on my understanding of this change, we're supposed to manually run the build system with the target `lldb-framework-cleanup` before we perform an install. Is this the case? This seems most useful when you have a script that controls the build process (e.g. swift's `build-script`).
> I suppose this doesn't really change anything if you don't know about this new target, but it would be useful to document this somewhere (perhaps in `docs/resources/build.rst`?)
>
>> Making this a dependency of the install target is not sufficient as the target needs to be build before the install phase.
>
> I can see why making the `install` target depend on `lldb-framework-cleanup` is not good, but what about making it a dependency of the target that installs the framework? I think it's something like `install-liblldb`? You could then guarantee that the cleanup happens before we install the framework. Maybe this is still too naïve or brittle though, what do you think?

Interesting, I tried the exact thing that you described and my custom command wasn't run, but I cannot reproduce that anymore. I don't know what I did differently then, but as this seems to work and is clearly more desirable, I'll update the patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141021/new/

https://reviews.llvm.org/D141021