[Lldb-commits] [lldb] 0dc7ecb - Fix typeo in LoadBinariesViaExhaustiveSearch when looking for kernel

[Jason Molenda via lldb-commits]

Author: Jason Molenda
Date: 2023-01-04T16:11:51-08:00
New Revision: 0dc7ecb1a70ec9f6eb41ebb4d1edf5d2acdfb4ce

URL: https://github.com/llvm/llvm-project/commit/0dc7ecb1a70ec9f6eb41ebb4d1edf5d2acdfb4ce
DIFF: https://github.com/llvm/llvm-project/commit/0dc7ecb1a70ec9f6eb41ebb4d1edf5d2acdfb4ce.diff

LOG: Fix typeo in LoadBinariesViaExhaustiveSearch when looking for kernel

As a last resort, with a Mach-O corefile, lldb will iterate through
all memory segments looking for a dyld binary (for a userland process
core dump) or an xnu kernel binary (kernel coredump).  We often
have metadata via LC_NOTEs so this final search mechanism is not
needed.  During the rewrite in https://reviews.llvm.org/D133680 I
did not handle the case of finding the xnu kernel by exhaustive
search correctly.

rdar://103813200

Added: 
    

Modified: 
    lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp b/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
index 593dc8535e641..fbf57fc3bf8e3 100644
--- a/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
+++ b/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
@@ -357,7 +357,7 @@ void ProcessMachCore::LoadBinariesViaExhaustiveSearch() {
         if (dyld != LLDB_INVALID_ADDRESS)
           dylds_found.push_back(dyld);
         if (kernel != LLDB_INVALID_ADDRESS)
-          kernels_found.push_back(dyld);
+          kernels_found.push_back(kernel);
       }
     }
   }