[Lldb-commits] [lldb] 7174568 - [lldb] Remove spurious `n` at the end of option error message

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 3 08:33:12 PST 2023


Author: Jonas Devlieghere
Date: 2023-01-03T08:31:09-08:00
New Revision: 7174568c9ccf2959b95563252c1bdbf59c5746c7

URL: https://github.com/llvm/llvm-project/commit/7174568c9ccf2959b95563252c1bdbf59c5746c7
DIFF: https://github.com/llvm/llvm-project/commit/7174568c9ccf2959b95563252c1bdbf59c5746c7.diff

LOG: [lldb] Remove spurious `n` at the end of option error message

When migrating to `ReportError` the newline (`\n`) at the end of the
error message was meant to be removed, but instead only the backslash
got deleted.

Added: 
    

Modified: 
    lldb/source/Interpreter/Options.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Interpreter/Options.cpp b/lldb/source/Interpreter/Options.cpp
index f5cf27c0ca6d..8cb386f95f43 100644
--- a/lldb/source/Interpreter/Options.cpp
+++ b/lldb/source/Interpreter/Options.cpp
@@ -238,7 +238,7 @@ Option *Options::GetLongOptions() {
               llvm::formatv(
                   "option[{0}] --{1} has a short option {2:x} that "
                   "conflicts with option[{3}] --{4}, short option won't "
-                  "be used for --{5}n",
+                  "be used for --{5}",
                   (int)i, defs[i].long_option, short_opt, pos->second,
                   m_getopt_table[pos->second].definition->long_option,
                   defs[i].long_option)
@@ -1007,7 +1007,7 @@ llvm::Expected<Args> Options::ParseAlias(const Args &args,
     // given) from the argument list.  Also remove them from the
     // raw_input_string, if one was passed in.
     // Note: We also need to preserve any option argument values that were
-    // surrounded by backticks, as we lose track of them in the 
+    // surrounded by backticks, as we lose track of them in the
     // option_args_vector.
     size_t idx =
         FindArgumentIndexForOption(args_copy, long_options[long_options_index]);
@@ -1339,7 +1339,7 @@ llvm::Expected<Args> Options::Parse(const Args &args,
       // If the Option setting returned an error, we should stop parsing
       // and return the error.
       if (error.Fail())
-        break;      
+        break;
     } else {
       error.SetErrorStringWithFormat("invalid option with value '%i'", val);
     }


        


More information about the lldb-commits mailing list