[Lldb-commits] [PATCH] D140759: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

Lu Weining via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 30 02:05:41 PST 2022


SixWeining accepted this revision.
SixWeining added a comment.
This revision is now accepted and ready to land.

LGTM from the LoongArch side. Thanks.



================
Comment at: lldb/unittests/Instruction/LoongArch/TestLoongArchEmulator.cpp:154
+  opcode = opcode >> 2;
+  return opcode << 26 | offs15_0 << 10 | bcxxz << 8 | cj << 5 | offs20_16;
+}
----------------
Seems you can use `opcode & 0b11` directly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140759/new/

https://reviews.llvm.org/D140759



More information about the lldb-commits mailing list