[Lldb-commits] [PATCH] D140249: [lldb] Do not deallocate memory after exec

[Alex Langford via Phabricator via lldb-commits]

bulbazord added inline comments.


================
Comment at: lldb/source/Target/Memory.cpp:337
   std::lock_guard<std::recursive_mutex> guard(m_mutex);
-  if (m_process.IsAlive()) {
+  if (m_process.IsAlive() && !did_exec) {
     PermissionsToBlockMap::iterator pos, end = m_memory_map.end();
----------------
jasonmolenda wrote:
> Should we comment that if we've just exec'ed, the inferior is a new process and does not have these memory regions allocated.
Yeah, I think that would be helpful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140249/new/

https://reviews.llvm.org/D140249