[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 16 05:21:46 PST 2022


mib added inline comments.


================
Comment at: lldb/bindings/python/python-wrapper.swig:317
 
+PythonObject lldb_private::LLDBSwigPythonCreateScriptedPlatform(
+    const char *python_class_name, const char *session_dictionary_name,
----------------
JDevlieghere wrote:
> This looks pretty similar to `LLDBSwigPythonCreateScriptedThread` and `LLDBSwigPythonCreateScriptedProcess`. Can we factor out the common parts?
True, but this need some refactor unrelated to this patch, so I'll do it in a follow-up


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139250/new/

https://reviews.llvm.org/D139250



More information about the lldb-commits mailing list