[Lldb-commits] [PATCH] D140092: [NFC][LLDB] Using namespace llvm in EmulateInstructionRISCV

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/source/Plugins/Instruction/RISCV/EmulateInstructionRISCV.h:21-22
 namespace lldb_private {
+using namespace llvm;
+using namespace lldb;
 
----------------
You cannot use `using namespace` in a header file. That pollutes the lldb_private namespace for everyone who includes this file. Please revert this immediately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140092/new/

https://reviews.llvm.org/D140092