[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

[Emmmer S via Phabricator via lldb-commits]

Emmmer marked an inline comment as done.
Emmmer added inline comments.


================
Comment at: lldb/source/Plugins/Instruction/RISCV/EmulateInstructionRISCV.cpp:1452
                              [&](auto &&rs1) {
-                               APFloat apf(APFloat::IEEEsingle(), rs1);
+                               APFloat apf(semantics(), rs1);
                                return inst.rd.WriteAPFloat(m_emu, apf);
----------------
DavidSpickett wrote:
> Can you explain the use of a callback here? At first glance it seems like you can just pass a value instead to APFloat.
Oh, I thought I should treat them like function calls.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140032/new/

https://reviews.llvm.org/D140032