[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

Thu Dec 15 03:30:52 PST 2022

Emmmer added a comment.

In D140032#3997384 <https://reviews.llvm.org/D140032#3997384>, @DavidSpickett wrote:

> Before I look closely, I see you added namespace llvm. This is fine, neatens things up but can we get that in its own change?

Sure, I will organize these into a separate patch.

> Also, llvm is moving to std::optional, can you do that and make it its own patch too? Of course add me to review both, should be pretty mechanical.

Are we going to use C++20 or something else? But I see the function `transform()` we need was introduced in C++23.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140032/new/

https://reviews.llvm.org/D140032