[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 15 02:50:46 PST 2022


DavidSpickett added a comment.

Is the further work in the commit message work you intended to include in this patch? I appreciate the status update might be useful for some but commit messages are for describing what's in a commit (among other things).

If you think people might wrongly assume that this commit contains support for "floating-point branch instructions", I would write something more explicit. For example "note that this does not include <things>, that will come in a later patch".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139833/new/

https://reviews.llvm.org/D139833



More information about the lldb-commits mailing list