[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

Before I look closely, I see you added namespace llvm. This is fine, neatens things up but can we get that in its own change?

Also, llvm is moving to std::optional, can you do that and make it its own patch too? Of course add me to review both, should be pretty mechanical.

Finally, it would be good to include the purpose of each extension in the commit message. The comments in source are great and you might as well repeat those in the commit message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140032/new/

https://reviews.llvm.org/D140032