[Lldb-commits] [PATCH] D140030: [lldb][TypeSystemClang][NFC] Make TemplateParameterInfos members private

Wed Dec 14 17:10:25 PST 2022

Michael137 added inline comments.

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2067

+        if (name && !name[0])
+          name = nullptr;
----------------
aprantl wrote:
> I wish we had a lazy version of StringRef that computes the length only on demand. How long does template_param_infos live? If it's only temporary, maybe we could just make it store StringRefs?
I think that would be feasible. Though for this NFC change I'd prefer just keeping the changes to a minimum. There is this subtle distinction between a `nullptr` name and an empty string literal which affects how parameter packs are handled. I suspect there's ways to simplify those codepaths and then start using `StringRef`s instead. I'll look into it after this patch lands

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140030/new/

https://reviews.llvm.org/D140030