[Lldb-commits] [PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

Wed Dec 14 05:53:13 PST 2022

serge-sans-paille marked 4 inline comments as done.
serge-sans-paille added a comment.

New version passes `ninja check` with clang, clang-tools-extra and lld.

================
Comment at: clang/lib/StaticAnalyzer/Core/CallDescription.cpp:39
 ento::CallDescription::CallDescription(CallDescriptionFlags Flags,
-                                       ArrayRef<const char *> QualifiedName,
+                                       ArrayRef<StringRef> QualifiedName,
                                        MaybeCount RequiredArgs /*= None*/,
----------------
steakhal wrote:
> Maybe we could restrict it even more to `StringLiteral`. The same applies to the other ctor.
It's not a strong requirements to have a `StringLiteral` here, as we generate an `std::string` from it anyway. Plus the conversion from *intiializer list of string literals* to `ArrayRef<StringLiteral>` is not infered by the compiler, so I'd rather not go that way (although I like the idea).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139881/new/

https://reviews.llvm.org/D139881