[Lldb-commits] [PATCH] D137900: Make only one function that needs to be implemented when searching for types.

[Adrian Prantl via Phabricator via lldb-commits]

aprantl accepted this revision.
aprantl added inline comments.


================
Comment at: lldb/include/lldb/Symbol/Type.h:101
+  /// Users will need to call one of the SetMatchContext() functions prior to
+  /// doing name lookups.
+  TypeQuery() = delete;
----------------
this comment is out of date and should probably just be deleted.


================
Comment at: lldb/include/lldb/Symbol/Type.h:270
+  bool GetFindOne() const { return (m_options & e_find_one) != 0; }
+  void SetFindOne(bool b) {
+    if (b)
----------------
Can we just delete this accessor?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137900/new/

https://reviews.llvm.org/D137900