[Lldb-commits] [PATCH] D139453: Switch to a different library-loaded notification function breakpoint in Darwin dyld

[Jim Ingham via Phabricator via lldb-commits]

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

This makes sense.  I think you should at least log if you can't read the memory dyld told you was where the image info should be.  Seems like this is the sort of thing that shouldn't happen, but if it does we probably want to say something.  Other than that minor grip, LGTM.



================
Comment at: lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp:314
+                  process->ReadPointerFromMemory(dyld_image_info, error);
+              if (error.Success()) {
                 image_load_addresses.push_back(addr);
----------------
Is it expected that this memory read fail?  It seems weird to just not handle that case at all?  Maybe at least log something here, otherwise it looks like we just get nothing w/o knowing why.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139453/new/

https://reviews.llvm.org/D139453