[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

[Alex Langford via Phabricator via lldb-commits]

bulbazord added a comment.

There's some overlap in implementation between `ScriptedPlatform::GetProcessInfo` and `ScriptedPlatform::FindProcesses`. If you don't anticipate these diverging dramatically, it might make sense to extract out common functionality into something like `ScriptedPlatform::ExtractProcessInfoFromDict` (or something to that effect).



================
Comment at: lldb/source/Plugins/Platform/scripted/ScriptedPlatform.cpp:1
+#include "ScriptedPlatform.h"
+
----------------
This file needs a header.


================
Comment at: lldb/source/Plugins/Platform/scripted/ScriptedPlatform.cpp:66-67
+
+  if (!metadata)
+    return {};
+
----------------
This was already checked above on line 60/61.


================
Comment at: lldb/source/Plugins/Platform/scripted/ScriptedPlatform.cpp:143
+
+  if (host_os == llvm::Triple::MacOSX) {
+    // We can't use x86GetSupportedArchitectures() because it uses
----------------
This should be unconditionally true because you set `host_os` to `llvm::Triple::MacOSX` right above this.


================
Comment at: lldb/source/Plugins/Platform/scripted/ScriptedPlatform.h:1
+//===-- PlatformPOSIX.h -----------------------------------------*- C++ -*-===//
+//
----------------
`PlatformPOSIX.h` -> `ScriptedPlatform.h`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139252/new/

https://reviews.llvm.org/D139252