[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added inline comments.


================
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:43-46
+            Dict: The processes represented as a dictionary, with at least the
+                process ID, name, architecture. Optionally, the user can also
+                provide the parent process ID and the user and group IDs.
+                The dictionary can be empty.
----------------
bulbazord wrote:
> I think you could add a little more information here. Based on the example below with `MyScriptedPlatform` it looks like the Dictionary maps `PID (int)` to `Process information (dict)`. However, what you've written here doesn't indicate that. You could change the example above to be something like:
> 
> ```
> processes = {
>     420: {
>             name: a.out,
>             arch: aarch64,
>             pid: 420,
>             parent_pid: 42 (optional),
>             uid: 0 (optional),
>             gid: 0 (optional),
>     },
> }
Good point!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139250/new/

https://reviews.llvm.org/D139250