[Lldb-commits] [PATCH] D139054: Delay calling ObjC class list read utility functions very early in process startup

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 6 11:07:10 PST 2022


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lldb/tools/debugserver/source/RNBRemote.h:111-139
+    prefix_reg_packets_with_tid,    // 'QPrefixRegisterPacketsWithThreadID
+    set_logging_mode,               // 'QSetLogging:'
+    set_ignored_exceptions,         // 'QSetIgnoredExceptions'
+    set_max_packet_size,            // 'QSetMaxPacketSize:'
+    set_max_payload_size,           // 'QSetMaxPayloadSize:'
+    set_environment_variable,       // 'QEnvironment:'
+    set_environment_variable_hex,   // 'QEnvironmentHexEncoded:'
----------------
Nit, since you're touching this, why not align it with `'QStartNoAckMode'`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139054/new/

https://reviews.llvm.org/D139054



More information about the lldb-commits mailing list