[Lldb-commits] [PATCH] D139102: [AArch64] Inline AArch64TargetParser.def

Mon Dec 5 21:06:49 PST 2022

andrewrk added a comment.

In D139102#3963388 <https://reviews.llvm.org/D139102#3963388>, @DavidSpickett wrote:

> 

> @andrewrk I seem to remember that Zig uses these files for generating compiler options of its own? A basic search didn't show anything but we'd better check if you're using them still.

Thanks for thinking of me.

Zig uses the .td files directly, with this script: https://github.com/ziglang/zig/blob/0.10.0/tools/update_cpu_features.zig

So, in this case, unless you're changing the data layout of AArch64.td, our script will be unaffected. Even if you did change it though, it would be OK - I have no expectation for this data to be stable, and this script is run offline only when upgrading to a new LLVM version. So I fully expect to have to rewrite this script in the future.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139102/new/

https://reviews.llvm.org/D139102