[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

[Hui Li via Phabricator via lldb-commits]

lh03061238 updated this revision to Diff 480297.
lh03061238 edited the summary of this revision.
lh03061238 added a comment.

(1) Use sort alphabetically in the following file
lldb/source/Plugins/Instruction/CMakeLists.txt
lldb/source/Plugins/Instruction/LoongArch/CMakeLists.txt
lldb/tools/lldb-server/CMakeLists.txt
lldb/tools/lldb-server/SystemInitializerLLGS.cpp

(2) Use ALL_CAPS for include guard symbol

(3) Modify the following functions
SupportsThisInstructionType(InstructionType inst_type)
GetOpcodeForInstruction(uint32_t inst)
EvaluateInstruction(uint32_t options)
CreateInstance(const ArchSpec &arch,InstructionType inst_type)

(4) Added TODO description in GetOpcodeForInstruction(uint32_t inst)

(5) Use #if defined(__loongarch__) in lldb/tools/lldb-server/SystemInitializerLLGS.cpp

(6) Remove the example from commit message


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139158/new/

https://reviews.llvm.org/D139158

Files:
  lldb/source/Plugins/Instruction/CMakeLists.txt
  lldb/source/Plugins/Instruction/LoongArch/CMakeLists.txt
  lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.cpp
  lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.h
  lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
  lldb/source/Plugins/Process/Utility/NativeProcessSoftwareSingleStep.cpp
  lldb/tools/lldb-server/CMakeLists.txt
  lldb/tools/lldb-server/SystemInitializerLLGS.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139158.480297.patch
Type: text/x-patch
Size: 12662 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20221206/e58f9d3f/attachment.bin>