[Lldb-commits] [PATCH] D139247: [lldb/Interpreter] Make ScriptedProcessInfo more generic

[Med Ismail Bennani via Phabricator via lldb-commits]

mib marked an inline comment as done.
mib added inline comments.


================
Comment at: lldb/include/lldb/Interpreter/ScriptedMetadata.h:36
+
+  std::string GetClassName() const { return m_class_name; }
+  StructuredData::DictionarySP GetArgsSP() const { return m_args_sp; }
----------------
JDevlieghere wrote:
> Why return a copy? Can this be a StringRef?
I guess we can return a `StringRef` but the member type still needs to be `std::string` to keep ownership.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139247/new/

https://reviews.llvm.org/D139247