[Lldb-commits] [PATCH] D139361: [lldb-tests] Force system's libcxx on tests failing with debug symbols

[Felipe de Azevedo Piovezan via Phabricator via lldb-commits]

fdeazeve updated this revision to Diff 480214.
fdeazeve added a comment.

Add FIXME comment with the same observation from the commit message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139361/new/

https://reviews.llvm.org/D139361

Files:
  lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/Makefile
  lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/Makefile
  lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/Makefile


Index: lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/Makefile
===================================================================
--- lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/Makefile
+++ lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/Makefile
@@ -1,3 +1,5 @@
-USE_LIBCPP := 1
+# FIXME: once the expression evaluator can handle std libraries with debug
+# info, change this to USE_LIBCPP=1
+USE_SYSTEM_STDLIB := 1
 CXX_SOURCES := main.cpp
 include Makefile.rules
Index: lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/Makefile
===================================================================
--- lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/Makefile
+++ lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/Makefile
@@ -1,3 +1,5 @@
-USE_LIBCPP := 1
+# FIXME: once the expression evaluator can handle std libraries with debug
+# info, change this to USE_LIBCPP=1
+USE_SYSTEM_STDLIB := 1
 CXX_SOURCES := main.cpp
 include Makefile.rules
Index: lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/Makefile
===================================================================
--- lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/Makefile
+++ lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/Makefile
@@ -1,3 +1,5 @@
-USE_LIBCPP := 1
+# FIXME: once the expression evaluator can handle std libraries with debug
+# info, change this to USE_LIBCPP=1
+USE_SYSTEM_STDLIB := 1
 CXX_SOURCES := main.cpp
 include Makefile.rules


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139361.480214.patch
Type: text/x-patch
Size: 1662 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20221205/66a117b8/attachment-0001.bin>