[Lldb-commits] [PATCH] D137900: Make only one function that needs to be implemented when searching for types.

[Adrian Prantl via Phabricator via lldb-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks for bearing with me. I think this is good now. One last suggestion I have is to turn the bools into an enum, so we can't accidentally mix their order up. Otherwise this LGTM!



================
Comment at: lldb/include/lldb/Symbol/Type.h:139
+
+  TypeQuery(llvm::StringRef name, bool exact_match, bool find_one);
+  /// Construct a type match object that matches a type basename that exists
----------------
Should this be an enum a la `TypeQuery::e_exact_match | e_first_only`?


================
Comment at: lldb/include/lldb/Symbol/Type.h:275
+  bool GetFindOne() const { return m_find_one; }
+  void SetFindOne(bool b) { m_find_one = b; }
+
----------------
We shouldn't need this if it's in the constructor?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137900/new/

https://reviews.llvm.org/D137900