[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D138618#3967933 <https://reviews.llvm.org/D138618#3967933>, @ayermolo wrote:

> How would you like me to break up this diff? Is factoring OSO into another diff enough, or do you want more granular one?

Hard to say without seeing what the patches would look like, but yes, in general, I'd say that the OSO/DIERef integration is the most fundamental part of this patch, and I'd optimize things such that this part stands out as much as possible. If you can do that, then maybe everything else can be in the second patch (sequenced either before or after it). Another obvious patch could be to create formatv-based version of the Module::ReportWarning function, and all of the PRIx64 parts of this patch to call that instead. That will reduce the blast radius of the subsequent dw_offset_t size change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138618/new/

https://reviews.llvm.org/D138618