[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

[Michael Buch via Phabricator via lldb-commits]

Michael137 added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:765
+        m_ast.CreateClassTemplateSpecializationType(class_specialization_decl);
+    return clang_type.GetTypeName(/*BaseOnly*/ true);
+  }
----------------
Michael137 wrote:
> Ok so what we're doing is:
> 1. Create a `ClassTemplateSpecializationDecl` with an empty basename
> 2. Return the type-name and since the basename is empty we end up with just the template arguments
> 
> Why can't we just call `GetTemplateParametersString(die)` instead of creating this function?
Can confirm that this works locally. Though required moving that function out of the DWARFASTParserClang, which seems OK


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138834/new/

https://reviews.llvm.org/D138834