[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 30 09:35:11 PST 2022


aprantl added inline comments.


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxRangesRefView.cpp:36
+  lldb::ValueObjectSP GetChildAtIndex(size_t idx) override {
+    // Since we only have a single child, return it
+    assert(idx == 0);
----------------
To be very nitpicking: LLVM style wants full sentences in comments, so let's add a `.` at the end. :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138558/new/

https://reviews.llvm.org/D138558



More information about the lldb-commits mailing list