[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

[Adrian Vogelsgesang via Phabricator via lldb-commits]

avogelsgesang added a comment.

The issue with this change was that if devirtualization is failing, then in the line

  lldb::ValueObjectSP promise = CreateValueObjectFromAddress(
        "promise", frame_ptr_addr + 2 * ptr_size, exe_ctx, promise_type);

the `promise_type` is `void`. Creating an object of type void is obviously not possible.

Adding a simple additional `!promise_type.isVoid()` check will fix this. Waiting for resolution of the test failure on https://reviews.llvm.org/D132735 first, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132815/new/

https://reviews.llvm.org/D132815