[Lldb-commits] [PATCH] D138310: [NFC] Make headers self-contained.

Tue Nov 29 04:00:16 PST 2022

rupprecht marked an inline comment as done.
rupprecht added inline comments.

================
Comment at: lldb/source/Plugins/Instruction/RISCV/RISCVInstructions.h:15

-#include "EmulateInstructionRISCV.h"
 #include "llvm/ADT/Optional.h"
----------------
MaskRay wrote:
> I assume that this is correct, even after considering IWYU. Perhaps worth a double check.
Thanks, I double checked: the only top-level type exported by `EmulateInstructionRISCV.h` is `class EmulateInstructionRISCV`. That's forward-declared in this file (line 20 on the base side), and only ever referred to by reference, so a forward declare is fully sufficient for that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138310/new/

https://reviews.llvm.org/D138310