[Lldb-commits] [lldb] c1a419c - [lldb][JITLoaderGDB] Resolve __jit_debug_register_code as eSymbolTypeCode

[Stefan Gränitz via lldb-commits]

Author: Stefan Gränitz
Date: 2022-11-27T11:45:26+01:00
New Revision: c1a419c6cf6db04008b416a58332777fb6887e2d

URL: https://github.com/llvm/llvm-project/commit/c1a419c6cf6db04008b416a58332777fb6887e2d
DIFF: https://github.com/llvm/llvm-project/commit/c1a419c6cf6db04008b416a58332777fb6887e2d.diff

LOG: [lldb][JITLoaderGDB] Resolve __jit_debug_register_code as eSymbolTypeCode

Fix failling jit-loader tests with BUILD_SHARED_LIBS as discussed in https://github.com/llvm/llvm-project/issues/56085

Reviewed By: mgorny

Differential Revision: https://reviews.llvm.org/D138750

Added: 
    

Modified: 
    lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
    lldb/test/Shell/Breakpoint/jit-loader_jitlink_elf.test
    lldb/test/Shell/Breakpoint/jit-loader_rtdyld_elf.test

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp b/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
index 3825c0bc09c77..7b810c0fee434 100644
--- a/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
+++ b/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
@@ -190,7 +190,7 @@ void JITLoaderGDB::SetJITBreakpoint(lldb_private::ModuleList &module_list) {
             __FUNCTION__);
 
   addr_t jit_addr = GetSymbolAddress(
-      module_list, ConstString("__jit_debug_register_code"), eSymbolTypeAny);
+      module_list, ConstString("__jit_debug_register_code"), eSymbolTypeCode);
   if (jit_addr == LLDB_INVALID_ADDRESS)
     return;
 

diff  --git a/lldb/test/Shell/Breakpoint/jit-loader_jitlink_elf.test b/lldb/test/Shell/Breakpoint/jit-loader_jitlink_elf.test
index 86c200fbc51fd..bbb4830a416b5 100644
--- a/lldb/test/Shell/Breakpoint/jit-loader_jitlink_elf.test
+++ b/lldb/test/Shell/Breakpoint/jit-loader_jitlink_elf.test
@@ -1,6 +1,4 @@
 # REQUIRES: target-x86_64
-# https://github.com/llvm/llvm-project/issues/56085
-# XFAIL: system-freebsd
 # XFAIL: system-windows
 
 # JITLink is the Orc-specific JIT linker implementation.

diff  --git a/lldb/test/Shell/Breakpoint/jit-loader_rtdyld_elf.test b/lldb/test/Shell/Breakpoint/jit-loader_rtdyld_elf.test
index aaefab831714c..8c289e2870ae6 100644
--- a/lldb/test/Shell/Breakpoint/jit-loader_rtdyld_elf.test
+++ b/lldb/test/Shell/Breakpoint/jit-loader_rtdyld_elf.test
@@ -1,6 +1,4 @@
 # REQUIRES: target-x86_64
-# https://github.com/llvm/llvm-project/issues/56085
-# XFAIL: system-freebsd
 # XFAIL: system-windows
 
 # RuntimeDyld can be used to link and load emitted code for both, MCJIT and Orc.