[Lldb-commits] [PATCH] D138750: [lldb][JITLoaderGDB] Resolve __jit_debug_register_code as eSymbolTypeCode

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz created this revision.
sgraenitz added reviewers: mgorny, labath.
Herald added a project: All.
sgraenitz requested review of this revision.
Herald added a project: LLDB.

Fix failling jit-loader tests in SHARED_LIBS build as discussed in https://github.com/llvm/llvm-project/issues/56085


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138750

Files:
  lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
  lldb/test/Shell/Breakpoint/jit-loader_jitlink_elf.test
  lldb/test/Shell/Breakpoint/jit-loader_rtdyld_elf.test


Index: lldb/test/Shell/Breakpoint/jit-loader_rtdyld_elf.test
===================================================================
--- lldb/test/Shell/Breakpoint/jit-loader_rtdyld_elf.test
+++ lldb/test/Shell/Breakpoint/jit-loader_rtdyld_elf.test
@@ -1,6 +1,4 @@
 # REQUIRES: target-x86_64
-# https://github.com/llvm/llvm-project/issues/56085
-# XFAIL: system-freebsd
 # XFAIL: system-windows
 
 # RuntimeDyld can be used to link and load emitted code for both, MCJIT and Orc.
Index: lldb/test/Shell/Breakpoint/jit-loader_jitlink_elf.test
===================================================================
--- lldb/test/Shell/Breakpoint/jit-loader_jitlink_elf.test
+++ lldb/test/Shell/Breakpoint/jit-loader_jitlink_elf.test
@@ -1,6 +1,4 @@
 # REQUIRES: target-x86_64
-# https://github.com/llvm/llvm-project/issues/56085
-# XFAIL: system-freebsd
 # XFAIL: system-windows
 
 # JITLink is the Orc-specific JIT linker implementation.
Index: lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
===================================================================
--- lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
+++ lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
@@ -190,7 +190,7 @@
             __FUNCTION__);
 
   addr_t jit_addr = GetSymbolAddress(
-      module_list, ConstString("__jit_debug_register_code"), eSymbolTypeAny);
+      module_list, ConstString("__jit_debug_register_code"), eSymbolTypeCode);
   if (jit_addr == LLDB_INVALID_ADDRESS)
     return;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138750.478072.patch
Type: text/x-patch
Size: 1469 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20221126/cdd673df/attachment.bin>