[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

In D132624#3951525 <https://reviews.llvm.org/D132624#3951525>, @avogelsgesang wrote:

> @jasonmolenda I am a bit confused about your revert.
> Did you indeed revert this change here? Afaict, you reverted https://reviews.llvm.org/D132735 and https://reviews.llvm.org/D132815, but left this commit in place. I did not actually read through your code changes, though, I only looked at the commit messages so far. Is my understanding of which commits you actually reverted correct?

Ah sigh. :(   I reverted both https://reviews.llvm.org/D132624 and https://reviews.llvm.org/D132735 -- failed to comment here in https://reviews.llvm.org/D132624 that I reverted the change, and put the comment about https://reviews.llvm.org/D132735 in the wrong phabracator.  I don't know how I got the two mixed up in so many ways ;) but they are both backed out right now and we have a green status on the macOS Incremental CI bot https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/

The mixup I can see, but I don't know how I failed to comment in this one about it being reverted.  I must not have hit a Submit button, apologies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132624/new/

https://reviews.llvm.org/D132624