[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

Fri Nov 25 12:24:56 PST 2022

jasonmolenda added a comment.

I reverted this change for now to unblock the macOS CI bots.

  commit a410b34a66accd864b174b6330d3d353e73f54d8
  Author: Jason Molenda <jason at molenda.com>
  Date:   Fri Nov 25 12:15:47 2022 -0800

      Revert "[LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer"

      This reverts commit cd3091a88f7c55c90d9b5fff372ce1cdfc71948d.

      This change crashes on macOS systems in
      formatters::StdlibCoroutineHandleSyntheticFrontEnd when
      it fails to create the `ValueObjectSP promise` and calls
      a method on it.  The failure causes a segfault while running
      TestCoroutineHandle.py on the "LLDB Incremental" CI bot,
      https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/

      This change originally landed via https://reviews.llvm.org/D132815

I saw in the description, " As noticed in https://reviews.llvm.org/D132624
by @labath, this can lead to an endless loop in lldb during printing
if the coroutine frame pointers form a cycle." - if we should revert further changes until this can be all addressed, that's fine, we'll see how the bots react.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132815/new/

https://reviews.llvm.org/D132815