[Lldb-commits] [PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

[Fangrui Song via Phabricator via lldb-commits]

MaskRay added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:218
+  explicit NameLookup(std::nullopt_t) : Data(nullptr, true) {}
   explicit NameLookup(std::nullptr_t) : Data(nullptr, false) {}
   NameLookup() : NameLookup(nullptr) {}
----------------
A maintainer might want to check the uses. Having 3 constructors looks confusing to readers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138539/new/

https://reviews.llvm.org/D138539