[Lldb-commits] [PATCH] D138589: Add runToBinaryEntry option for lldb-vscode

[Greg Clayton via Phabricator via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

We have to let the IDE set breakpoints after the "initialized" packet is sent and _then_ do this functionality. So this patch needs to be modified to make that happen.



================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1807-1809
+  if (error.Success())
+    error = RunToBinaryEntry();
+
----------------
If this synchronously runs to the entry point of the program prior to letting the IDE set breakpoints (which happens when the "initialized" packet is sent), then we can't do this. We can miss breakpoints if they are set in the C++ global initializer lists. The flow with this in here will not stop at the entry point and allow the IDE to set breakpoints first and this must happen. 


================
Comment at: lldb/tools/lldb-vscode/package.json:162
+								"type": "boolean",
+								"description": "run to program entry one-shot breakpoint during launch to ensure dependency modules are loaded.",
+								"default": false
----------------
Description should be capitalized correct and the language is a bit off "run to program entry one-shot breakpoint"? Did you mean "run to program entry using a one-shot breakpoint"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138589/new/

https://reviews.llvm.org/D138589