[Lldb-commits] [PATCH] D138536: Fix TestVSCode_launch.py test failure

jeffrey tan via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 22 18:18:12 PST 2022


yinghuitan created this revision.
yinghuitan added reviewers: clayborg, GeorgeHuyubo, kusmour.
Herald added a project: All.
yinghuitan requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

We changed the output to telemetry category but the test code did not change. 
This patch fixes the test failure.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138536

Files:
  lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
  lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py


Index: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
===================================================================
--- lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
+++ lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
@@ -89,8 +89,8 @@
         self.build_and_launch(program, runToBinaryEntry=True)
         self.set_function_breakpoints(['main'])
         stopped_events = self.continue_to_next_stop()
-        console_output = self.get_console()
-        self.assertIn("Process stopped successfully at the binary's entry point", console_output)
+        telemetry = self.get_telemetry()
+        self.assertIn("Process stopped successfully at the binary's entry point", telemetry)
 
         for stopped_event in stopped_events:
             if 'body' in stopped_event:
Index: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
+++ lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
@@ -188,6 +188,9 @@
     def get_console(self, timeout=0.0):
         return self.vscode.get_output('console', timeout=timeout)
 
+    def get_telemetry(self, timeout=0.0):
+        return self.vscode.get_output('telemetry', timeout=timeout)
+
     def collect_console(self, duration):
         return self.vscode.collect_output('console', duration=duration)
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138536.477364.patch
Type: text/x-patch
Size: 1492 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20221123/bddcd7f4/attachment.bin>


More information about the lldb-commits mailing list