[Lldb-commits] [PATCH] D137338: Fix dupe word typos

Nico Weber via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 8 05:46:08 PST 2022


thakis added inline comments.
Herald added a reviewer: njames93.


================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:47
   // complete architecture list, nor a reasonable subset. The problem is that
-  // historically the driver driver accepts this and also ties its -march=
   // handling to the architecture name, so we need to be careful before removing
----------------
aaron.ballman wrote:
> This is duplicated just often enough and in just enough contexts where I think "driver driver" means "the driver that drives another driver", but it'd be nice if someone else could confirm or deny that.
I think that's correct. IIRC, the "driver driver" was a feature in apple gcc long ago, and it was a driver that invoked the gcc driver once per `-arch` or some such. One of the early goals of clang was to just have a driver, but no driver driver.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137338/new/

https://reviews.llvm.org/D137338



More information about the lldb-commits mailing list