[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

[Jorge Gorbe Moya via Phabricator via lldb-commits]

jgorbe added a comment.

In D137000#3915943 <https://reviews.llvm.org/D137000#3915943>, @jingham wrote:

> It is a bit odd to follow the what the help summary says is a valid option set and then get an error.   But this is a corner case, and since you say explicitly that you can't provide both that's probably good enough.  Would you mind changing "Incompatible with" to: "Cannot be specified at the same time as".  Incompatible isn't precise - does it mean you can't use them both, or that if you do something weird will happen?

After following Pavel's suggestion to remove the short flag it doesn't show up at all in the help summary, so the help summary still shows a valid option set. It just lists the long flag for the new option in the detailed list after the summary, like this:

  Command Options Usage:
    type summary add -c [-Oprvx] [-C <boolean>] [-w <name>] <name> [<name> [...]]
    type summary add [-ehprvx] -s <summary-string> [-C <boolean>] [-w <name>] [-n <name>] <name> [<name> [...]]
    type summary add [-Pehprvx] [-C <boolean>] [-w <name>] [-n <name>] [-F <python-function>] [-o <python-script>] <name> [<name> [...]]
  
         --recognizer-function
              The names in the argument list are actually the names of python functions that decide whether to use this summary for any given type. Cannot be specified at the same time as --regex (-x).



> Other than that, this is fine.  Thanks for working on this.

Thank you both for helping me land this feature! :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137000/new/

https://reviews.llvm.org/D137000