[Lldb-commits] [PATCH] D137614: [trace] Add a new call graph reconstructor
Jakob Johnson via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Nov 8 10:09:55 PST 2022
jj10306 added inline comments.
================
Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:296
std::vector<TraceItemStorage> m_item_data;
+ std::vector<TraceInstructionExtraInfo> m_insn_extra_info;
/// The TraceItemKind for each trace item encoded as uint8_t. We don't include
----------------
do we need to store this or can this information be calculated on demand? just thinking about massive traces and want to make sure we're intentional about only storing what we absolutely need to for each instruction
================
Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:317
events_stats.total_count);
- for (const auto &event_to_count : events_stats.events_counts) {
- s.Format(" {0}: {1}\n",
- TraceCursor::EventKindToString(event_to_count.first),
- event_to_count.second);
+ for (auto it = events_stats.events_counts.begin();
+ it != events_stats.events_counts.end(); ++it) {
----------------
what's the reason for this change?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137614/new/
https://reviews.llvm.org/D137614
More information about the lldb-commits
mailing list