[Lldb-commits] [PATCH] D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API

[Will Hawkins via Phabricator via lldb-commits]

hawkinsw added inline comments.


================
Comment at: lldb/source/API/SBTraceCursor.cpp:131
+  const auto &maybe_wall_clock_time = m_opaque_sp->GetWallClockTime();
+  return maybe_wall_clock_time ? *maybe_wall_clock_time : -1.0;
+}
----------------
jj10306 wrote:
> open to suggestions on the best way to indicate that the current item doesn't have a timestamp associated with it
Could we use `llvm::Optional`? Sorry if that is a silly suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137645/new/

https://reviews.llvm.org/D137645